refactor: split main otel config into multiple connections, add tests #186
Conversation
obs-gh-mattcotter
force-pushed
the
OB-36266-config-refactor
branch
2 times, most recently
from
5e95cdb to
cd22dc3
Compare
|
|
||
| var configYaml, configMapstructure config.AgentConfig | ||
|
|
||
| // Decode via mapstrucutre (which is how viper does it) |
There was a problem hiding this comment.
nit typo mapstructure
| }, | ||
| []CollectorConfigFragment{ | ||
| { | ||
| enabledCheck: func(agentConfig *config.AgentConfig) bool { |
There was a problem hiding this comment.
these are basically the shared components between other connection types right? so if we add more connection types we'd need to add them to this check here too? any reason to not just always include this?
There was a problem hiding this comment.
That's right. I was thinking it would be nice to have a total noop mode (ie operate exactly like a vanilla otelcol), but it's probably not worth the extra complexity here. I changed this to always return true.
| }, | ||
| { | ||
| enabledCheck: func(agentConfig *config.AgentConfig) bool { | ||
| return agentConfig.Forwarding.Enabled |
There was a problem hiding this comment.
before there was no value here right? so if we change this to be default off, that's a breaking change I think. Same for the healthcheck below. do these default to on?
There was a problem hiding this comment.
These do default to on, but it happens via defaulting the Enabled variable to true in the config definition. I added "default" struct tags to config.AgentConfig and the go-defaults library to set them. The new TestAgentConfigFromViper validates that this works as intended.
obs-gh-mattcotter
force-pushed
the
OB-36266-config-refactor
branch
from
57a420f to
f9fce4b
Compare
obs-gh-mattcotter
force-pushed
the
OB-36266-config-refactor
branch
from
f9fce4b to
0e7e577
Compare
Description
OB-36266: Split main otel config into multiple connections. Use the agent config object as the source of truth instead of viper. Add tests.
I also tested this with the new
observe-agent config --render-otelcommand. I enabled all options in my agent config, and diffed the output betweenmainand this branch and only these lines changed:This is expected since the otel-collector.yaml file no longer exists.
Checklist